Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bump bytedance/sonic to v1.12.2 to fix compilation error with go 1.23.0 #35879

Merged
merged 1 commit into from
Sep 1, 2024
Merged

fix: bump bytedance/sonic to v1.12.2 to fix compilation error with go 1.23.0 #35879

merged 1 commit into from
Sep 1, 2024

Conversation

jiangyinzuo
Copy link
Contributor

fixes: #35878

@sre-ci-robot sre-ci-robot added area/dependency Pull requests that update a dependency file size/S Denotes a PR that changes 10-29 lines. labels Aug 30, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 30, 2024

@jiangyinzuo Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco DCO is missing in this pull request. kind/bug Issues or changes related a bug dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Aug 30, 2024
@jiangyinzuo jiangyinzuo changed the title fix: bump bytedance/sonic to v1.12.2 to fix compilation error fix: bump bytedance/sonic to v1.12.2 to fix compilation error with go 1.23.0 Aug 30, 2024
@xiaofan-luan
Copy link
Collaborator

@jiangyinzuo
thanks for the contribution. Your pr actually failed on testSearchV2 so please help on check

@xiaofan-luan
Copy link
Collaborator

might be simply some error message issue

@mergify mergify bot added the ci-passed label Aug 31, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.41%. Comparing base (311f860) to head (a62a7e2).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #35879      +/-   ##
==========================================
+ Coverage   79.84%   81.41%   +1.57%     
==========================================
  Files        1239     1252      +13     
  Lines      148031   149322    +1291     
==========================================
+ Hits       118194   121573    +3379     
+ Misses      25005    22891    -2114     
- Partials     4832     4858      +26

see 230 files with indirect coverage changes

@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiangyinzuo, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 407fc93 into milvus-io:master Sep 1, 2024
16 checks passed
tedxu pushed a commit to tedxu/milvus that referenced this pull request Nov 20, 2024
@jiangyinzuo @tedxu
fix: bump bytedance/sonic to v1.12.2 to fix compilation error with go…
de4461a 
… 1.23.0 (milvus-io#35879)

fixes: milvus-io#35878

Signed-off-by: Yinzuo Jiang <[email protected]>
tedxu pushed a commit to tedxu/milvus that referenced this pull request Nov 20, 2024
@jiangyinzuo @tedxu
fix: bump bytedance/sonic to v1.12.2 to fix compilation error with go…
ac20922 
… 1.23.0 (milvus-io#35879)

fixes: milvus-io#35878

Signed-off-by: Yinzuo Jiang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia Awaiting requested review from congqixia

@xige-16 xige-16 Awaiting requested review from xige-16

@zwd1208 zwd1208 Awaiting requested review from zwd1208

Assignees

@xiaofan-luan xiaofan-luan

Labels
approved area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Compilation error with go 1.23.0
3 participants
@jiangyinzuo @xiaofan-luan @sre-ci-robot