Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Compilation error with go 1.23.0 #35878

Closed
1 task done
jiangyinzuo opened this issue Aug 30, 2024 · 1 comment · Fixed by #35879
Closed
1 task done

[Bug]: Compilation error with go 1.23.0 #35878

jiangyinzuo opened this issue Aug 30, 2024 · 1 comment · Fixed by #35879
Assignees
@congqixia
Labels
kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@jiangyinzuo
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Environment

- Milvus version: master (311f860676133e94c5fc8367bc447a46b09b948c)
- Deployment mode(standalone or cluster):
- MQ type(rocksmq, pulsar or kafka):    
- SDK version(e.g. pymilvus v2.0.0rc2):
- OS(Ubuntu or CentOS): Ubuntu 22.04
- CPU/Memory: 
- GPU: 
- Others:

Current Behavior

When I run make to compile compile milvus, I got an error:

Go Version: go version go1.23.0 linux/amd64
Building Milvus ...
link: github.com/bytedance/sonic/ast: invalid reference to encoding/json.safeSet

Expected Behavior

According to bytedance/sonic#660 and https://github.com/bytedance/sonic/releases/tag/v1.12.2, we should bump bytedance/sonic to v1.12.2

Steps To Reproduce

make

Milvus Log

No response

Anything else?

No response
@jiangyinzuo jiangyinzuo added kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 30, 2024
jiangyinzuo added a commit to jiangyinzuo/milvus that referenced this issue Aug 30, 2024
@jiangyinzuo
fix: bump bytedance/sonic to v1.12.2 to fix compilation error
743a9bc 
fixes: milvus-io#35878
@jiangyinzuo jiangyinzuo mentioned this issue Aug 30, 2024
Merged
jiangyinzuo added a commit to jiangyinzuo/milvus that referenced this issue Aug 30, 2024
@jiangyinzuo
fix: bump bytedance/sonic to v1.12.2 to fix compilation error
c119c8e 
fixes: milvus-io#35878
Signed-off-by: Yinzuo Jiang <[email protected]>
jiangyinzuo added a commit to jiangyinzuo/milvus that referenced this issue Aug 30, 2024
@jiangyinzuo
fix: bump bytedance/sonic to v1.12.2 to fix compilation error with go…
05e4f19 
… 1.23.0

fixes: milvus-io#35878
Signed-off-by: Yinzuo Jiang <[email protected]>
@yanliang567
Copy link
Contributor

/assign @congqixia
please help to take a look
/unassign

jiangyinzuo added a commit to jiangyinzuo/milvus that referenced this issue Aug 31, 2024
@jiangyinzuo
fix: bump bytedance/sonic to v1.12.2 to fix compilation error with go…
a62a7e2 
… 1.23.0

fixes: milvus-io#35878
Signed-off-by: Yinzuo Jiang <[email protected]>
tedxu pushed a commit to tedxu/milvus that referenced this issue Nov 20, 2024
@jiangyinzuo @tedxu
fix: bump bytedance/sonic to v1.12.2 to fix compilation error with go…
de4461a 
… 1.23.0 (milvus-io#35879)

fixes: milvus-io#35878

Signed-off-by: Yinzuo Jiang <[email protected]>
tedxu pushed a commit to tedxu/milvus that referenced this issue Nov 20, 2024
@jiangyinzuo @tedxu
fix: bump bytedance/sonic to v1.12.2 to fix compilation error with go…
ac20922 
… 1.23.0 (milvus-io#35879)

fixes: milvus-io#35878

Signed-off-by: Yinzuo Jiang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@congqixia congqixia

Labels
kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: bump bytedance/sonic to v1.12.2 to fix compilation error with go 1.23.0 jiangyinzuo/milvus
3 participants
@jiangyinzuo @yanliang567 @congqixia