Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redo CI to remove individual gemfiles, Add Rails 7.1 and Ruby 3.3 #1108

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Redo CI to remove individual gemfiles, Add Rails 7.1 and Ruby 3.3 #1108

wants to merge 5 commits into from
+30 −88

Conversation

mathieujobin
Copy link
Contributor

Alternative to #1093

mathieujobin
mathieujobin commented Mar 13, 2024
View reviewed changes
.github/workflows/ci.yml
@@ -4,39 +4,29 @@ on: [push, pull_request, workflow_dispatch]

jobs:
tests:
name: Tests with Ruby ${{ matrix.ruby-version }} and Rails ${{ matrix.gemfile }}
name: CI Rails ${{ matrix.rails }} on ${{ matrix.ruby }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am making this shorter, so its easier to see the version on Actions details.
image

@mathieujobin
Copy link
Contributor Author

i used this pattern with apipie-rails and many other gems I maintain.

please review and consider merging.

@mathieujobin
Copy link
Contributor Author

@mileszs could take a look and consider merging this?

@n-rodriguez
Copy link
Contributor

Hi there! Why not using https://github.com/thoughtbot/appraisal ? It's the main purpose of this gem 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathieujobin @n-rodriguez