Skip to content

Commit

Permalink
fix cran note
Browse files Browse the repository at this point in the history
  • Loading branch information
milanwiedemann committed May 22, 2020
1 parent b6b3ec5 commit 0a247b6
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 41 deletions.
2 changes: 1 addition & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
- minor changes to integrate updates in tibble package

# suddengains 0.4.3
- Supress message about vector length from `extract_values()` in the functions `create_bysg()` and `create_byperson()`
- Suppress message about vector length from `extract_values()` in the functions `create_bysg()` and `create_byperson()`
- Update ggplot2 functions with "deprecated" warning message
- Add clearer detailed output message in `check_interval()` function

Expand Down
19 changes: 1 addition & 18 deletions R/describe_sg.R
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#' Show descriptives for the sudden gains datasets
#'
#' Some numbers (percentages) will be different depending which form of data set (bysg vs. byperson) is selected, because if multiple gains in bysg only one will be selected for further analyses.
#' Descriptives might differ between the bysg and byperson data sets depending on whether multiple gains are present.
#' @param data A \code{bysg} or \code{byperson} dataset created using the function \code{\link{create_bysg}} or \code{\link{create_byperson}}.
#' @param sg_data_structure String, indicating whether the input data is a \code{bysg} or \code{byperson} dataset.
#' @return A list, showing basic descriptive statistics for sudden gains within the dataset specified.
Expand Down Expand Up @@ -34,23 +34,6 @@
#' # Describe bysg dataset
#' describe_sg(data = bysg,
#' sg_data_structure = "bysg")
#'
#' # Create byperson dataset
#' byperson_first <- create_byperson(data = sgdata,
#' sg_crit1_cutoff = 7,
#' id_var_name = "id",
#' tx_start_var_name = "bdi_s1",
#' tx_end_var_name = "bdi_s12",
#' sg_var_list = c("bdi_s1", "bdi_s2", "bdi_s3",
#' "bdi_s4", "bdi_s5", "bdi_s6",
#' "bdi_s7", "bdi_s8", "bdi_s9",
#' "bdi_s10", "bdi_s11", "bdi_s12"),
#' sg_measure_name = "bdi",
#' multiple_sg_select = "first")
#'
#' # Describe byperson dataset
#' describe_sg(data = byperson_first,
#' sg_data_structure = "byperson")

describe_sg <- function(data, sg_data_structure = c("bysg", "byperson")) {

Expand Down
22 changes: 18 additions & 4 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,19 +1,33 @@
# Test environments
## local
* macOS Mojave 10.14.6
* R version 3.6.1 (2019-07-05)
* macOS Mojave 10.15.4
* R version 4.0.0 (2020-04-24) -- "Arbor Day"

## R CMD check results
* There were no ERRORs or WARNINGs, or NOTES

## travis-ci
* R version 3.6.2 (2017-01-27)
* R version 4.0.0 (2020-04-24)
* Platform: x86_64-pc-linux-gnu (64-bit)
* Running under: Ubuntu 16.04.6 LTS
* passing

## ci.appveyor
* R version 3.6.3 Patched (2020-02-29 r77919)
* R version 4.0.0 Patched (2020-05-18 r78487)
* Platform: x86_64-w64-mingw32/x64 (64-bit)
* Running under: Windows Server 2012 R2 x64 (build 9600)
* passing

## win-builder R-release
* using R version 4.0.0 (2020-04-24)
* using platform: x86_64-w64-mingw32 (64-bit)
* 1 Note

## win-builder R-devel
* using R Under development (unstable) (2020-05-19 r78492)
* using platform: x86_64-w64-mingw32 (64-bit)

## Resubmission
This is a resubmission.
I have shortened the examples from the describe_sg() function.
This function should no longer exceed the time limit.
19 changes: 1 addition & 18 deletions man/describe_sg.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 0a247b6

Please sign in to comment.