Enhance token management in cloud command handling

[d3dfantasy99]

Description

• Introduced a mechanism to check and refresh the IoT token before sending commands.
• Enhanced the send_cloud_command method to ensure token validity.
• Added error handling for token expiration scenarios.

---

Changes walkthrough 📝

Relevant files

Enhancement

cloud_gateway.py Enhance token management in cloud command handling              pymammotion/aliyun/cloud_gateway.py Added token check and refresh logic in send_cloud_command. Implemented check_or_refresh_session method to handle token expiration. Updated session management with new token attributes. +40/-4    session_by_authcode_response.py Update session response structure for token data                  pymammotion/aliyun/dataclass/session_by_authcode_response.py Modified SessionByAuthCodeResponse to include token data. Added field import for future enhancements. +2/-2

[mikey0000]

Need to create a token expired exception type so it can be caught

[mikey0000]

Unused import?

[mikey0000]

There should be a dataclass for this, so you can do e.g IotToken().from_dict(response_body_dict.get('data', {}))

Or create one, plenty of examples in the make-em-mow branch

[penify-dev]

PR Review 🔍

⏱️ Estimated effort to review [1-5]	4, because the changes involve significant modifications to token management and error handling, requiring careful review of both the logic and potential edge cases.
🧪 Relevant tests	No
⚡ Possible issues	Possible Bug: The logic for checking token expiration may not account for clock skew between the client and server, which could lead to premature token refresh attempts.
	Possible Bug: The error handling in check_or_refresh_session may not cover all scenarios, such as network failures or unexpected response formats.
🔒 Security concerns	No

[penify-dev]

PR Code Suggestions ✨

Category	Suggestion	Score
Possible issue	Add validation for the response dictionary to prevent KeyErrors Ensure that the response_body_dict is validated before accessing its keys to avoid potential KeyErrors. pymammotion/aliyun/cloud_gateway.py [445] -if int(response_body_dict.get("code")) != 200: +if "code" not in response_body_dict or int(response_body_dict["code"]) != 200: Suggestion importance[1-10]: 9 Why: The suggestion addresses a potential issue with KeyErrors, which is crucial for maintaining the robustness of the code.	9
Best practice	Replace the generic exception with a more specific exception type for clarity Consider using a more specific exception type instead of the generic Exception for better error handling and debugging. pymammotion/aliyun/cloud_gateway.py [517] -raise Exception("Refresh token expired. Please re-login") +raise RuntimeError("Refresh token expired. Please re-login") Suggestion importance[1-10]: 8 Why: This suggestion improves error handling by recommending a more specific exception type, which enhances clarity and debugging.	8
Maintainability	Log the error message before raising the exception for improved debugging Consider logging the error message in the exception for better debugging information. pymammotion/aliyun/cloud_gateway.py [446] +logger.error("Error check or refresh token: " + response_body_dict.get('msg', '')) raise Exception("Error check or refresh token: " + response_body_dict.get('msg', '')) Suggestion importance[1-10]: 8 Why: This suggestion enhances maintainability by recommending logging of error messages, which is beneficial for debugging.	8
Possible bug	Adjust the token expiration check to avoid potential future timestamp issues Ensure that the token expiration check accounts for the possibility of the token being issued in the future, which could lead to incorrect behavior. pymammotion/aliyun/cloud_gateway.py [512] -if self._iot_token_issued_at + self._session_by_authcode_response.data.iotTokenExpire <= (int(time.time()) + (5 * 3600)): +if self._iot_token_issued_at + self._session_by_authcode_response.data.iotTokenExpire <= int(time.time()): Suggestion importance[1-10]: 7 Why: The suggestion correctly identifies a potential issue with the token expiration check, but the proposed change may not fully consider the logic of the application.	7