Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor mode configuration | Add support for HYBRID | Add new CommitMode focused default config #1312

Merged
merged 3 commits into from
Mar 2, 2024

Conversation

mikepenz
Copy link
Owner

@mikepenz mikepenz commented Mar 2, 2024

  • introduce new mode configuration (replaces commitMode) with the option for PR, COMMIT or HYBRID (whereas hybrid has commits and PRs alongside)
  • introduce new default commit configuration automatically used if COMMIT mode is configured. this uses a label extractor to support conventional commits

…ption for `PR`, `COMMIT` or `HYBRID` (whereas hybrid has commits and PRs alongside)

- introduce new default commit configuration automatically used if `COMMIT` mode is configured. this uses a label extractor to support conventional commits
mikepenz added 2 commits March 2, 2024 20:23
…hing

- introduce test case to validate COMMIT mode with default conventional commit behavior
- introduce testcase to showcase custom placeholder and trim value to convert conventional commits to cleaned titles
@mikepenz mikepenz merged commit 991a95e into develop Mar 2, 2024
6 checks passed
@mikepenz mikepenz deleted the feature/adjust_mode_configuration branch March 2, 2024 20:28
@cyb3rko
Copy link

cyb3rko commented Mar 3, 2024

Hi Mike,
if I understand the changes the right way, it will break v4 configurations using commitMode, right?
Will there be some kind of migration note?

@mikepenz
Copy link
Owner Author

mikepenz commented Mar 4, 2024

@cyb3rko good day. So far everything should be backwards compatible. I kept even the commitMode flag which sets the mode internally.

@cyb3rko
Copy link

cyb3rko commented Mar 4, 2024

Awesome, thank you 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants