This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
root template now references commercial S3 buckets only #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hparr
approved these changes
Sep 30, 2019
mikeoleary
deleted the
work-moleary-consolidate-on-S3-bucket-commercial-and-gov
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will set the root template to reference "commercial" cloud S3 buckets only, and not GovCloud buckets for child templates. This will allow us to use the pipeline to maintain 1 set of templates only, regardless of whether customer deployments are from GovCloud or commercial.
Only 1 file currently is required to be hosted in a Govcloud S3 bucket, and that is /master/ha_iapp.zip which is referenced in creation of a lambda function.
This should close issue #70