fix: make setting the cipher suite as an array or suites #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix allows for cipher suites to now be set as an array or suites that are supported by the certificate/key pair provided. Doing so makes this more cosnistent with other fields like `versions` where a round-robin of cipher suite to use will be used.
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #6 +/- ##
==========================================
+ Coverage 56.99% 66.00% +9.01%
==========================================
Files 11 10 -1
Lines 937 809 -128
==========================================
Hits 534 534
+ Misses 352 222 -130
- Partials 51 53 +2 ☔ View full report in Codecov by Sentry. |
mikefero
force-pushed
the
fix/cipher_suite_array
branch
from
57d977f to
5f1ef2f
Compare
This initial codecov configuraiton file is being supplied to simply ignore main.go as there are no tests that will be included for this file.
mikefero
force-pushed
the
fix/cipher_suite_array
branch
from
5f1ef2f to
1c5b28e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix allows for cipher suites to now be set as an array or suites that are supported by the certificate/key pair provided. Doing so makes this more cosnistent with other fields like
versionswhere a round-robin of cipher suite to use will be used.This commit also adds a Codecov.io YAML configuration file which will currently ignore main.go as this file will not contain tests.