refactor protocol handlers #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the main function injects a `HandlerBuilder`, the Node uses it (plus node-specific info) to new protocol handlers, each manages the connection(s) privately. Signed-off-by: Javier Guerra <[email protected]>
Signed-off-by: Javier Guerra <[email protected]>
javierguerragiraldez
force-pushed
the
refactor-protocol-handlers
branch
from
097a0d2 to
36316b7
Compare
Signed-off-by: Javier Guerra <[email protected]>
doesn't do much beyond periodically asking for deltas because the specfile isn't ready yet. the current specfile was written as understood from the very first Lua implementation, there's a PR supposedly incorporating discussed changes (Kong/openrpc_specfiles#2), but no reviews from the Gateway team.
had to tweak the spec to add the `NewVersion` field to `Delta` elements. also added a WaitGroup to make Run close with the last connection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the main function injects a
HandlerBuilder, the Node uses it (plus node-specific info) to new protocol handlers, each manages the connection(s) privately.