Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animated Gif support #543

Open
dtonon opened this issue Oct 8, 2023 · 3 comments
Open

Animated Gif support #543

dtonon opened this issue Oct 8, 2023 · 3 comments
Labels
Bug Something isn't working Enhancement New feature or request UI/UX Related to interface and user experience

Comments

@dtonon
Copy link
Collaborator

dtonon commented Oct 8, 2023

Currently gif are not supported, only the first frame is shown.
I'm absolutely not a fan of lazy-animated-memes, but sometime gifs are a quick and useful way to share short/simple animation.

But first, there is a usability problem: by showing only the first frame, the poster's message could be completely misunderstood. Let's think about a GIF that starts with a provocative message, and then explains the meaning. The Gossip user will receive half the information, and this could create many problems.

@bu5hm4nn did you already check on this matter in the past?

@dtonon dtonon added Bug Something isn't working Enhancement New feature or request UI/UX Related to interface and user experience labels Oct 8, 2023
@mikedilger mikedilger changed the title Gif support Animated Gif support Oct 8, 2023
@bu5hm4nn
Copy link
Collaborator

bu5hm4nn commented Oct 9, 2023

emilk/egui#1857
emilk/egui#1521
TL;DR it's possible but we need to write some code to cycle through the frames and render them at the right time. I would guess maybe 2-3 days work with testing.

@zdimension
Copy link

Just in case, support for animated GIFs has been added in emilk/egui#4620.

@bu5hm4nn
Copy link
Collaborator

bu5hm4nn commented Aug 7, 2024

@zdimension Thanks for the heads up.
@mikedilger I just read the code for this, it only works with egui's image loaders. We could either switch to those (I know you didn't want to use them because we might loose control over network connections) or we implement their code on top of our loader.

@mikedilger mikedilger mentioned this issue Dec 3, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Enhancement New feature or request UI/UX Related to interface and user experience
Projects
None yet
Development

No branches or pull requests

3 participants