fix dbug crashes on 3rd party modules

mikeallisonJS · Aug 30, 2020 · 539e168 · 539e168
1 parent 5aec520
commit 539e168
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/DBug.cpp b/src/DBug.cpp
@@ -67,8 +67,10 @@ bool DBugDisplay::isConnected() {
 
 bool DBugDisplay::isSafe() {
     // TODO: Better bad parent module testing. Sadly, model pointer slug & id do not dereference properly
-    // At least test that dbug isn't being nested
-    return module->leftExpander.module->model != modelDBug;
+    auto leftExpanderModule = module->leftExpander.module;
+    bool notNested = leftExpanderModule->model != modelDBug;
+    bool isDBugable = dynamic_cast<CSModule*>(leftExpanderModule) != nullptr;
+    return notNested && isDBugable;
 }
 
 Model* modelDBug = createModel<DBug, DBugWidget>("DBug");