Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use export <value> in environment.d.ts #261

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

raghuvaran
Copy link

Fixes #260

@ghost
Copy link

ghost commented Nov 27, 2018

There were the following issues with this Pull Request

  • Commit: 2f22e23
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@mike-north
Copy link
Owner

Babel shouldn't care about .d.ts files, and we're figuring out what to do with environment.d.ts in general.

export = foo is important in terms of making sure CommonJS style imports align with type information properly (it.s the types equivalent of module.exports = foo).

Your change would break type-checking on something like the following code on the node.js side of things

// ember-cli-build.js

// NOTE: this is _not_ consuming the default export
const env = require('config/environment');

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants