This change only queues the exposed region to be repainted on UIKit. #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works, but it exposes a problem: scrolling of text (ls -l on a large directory) will redraw the text on top of the old text - this is caused by the clear background that I allow using. So I need to account for that. This sadly also brings back the ugly bar at the bottom, because the UIScrollView allows for over-scroll, and I do not seem to have a way of painting there. The solutions on StackOverflow include "Append a view underneat with the color that you want" which is some ugly stuff. Will investigate later.
migueldeicaza
force-pushed
the
ios-onlyRedrawExposedRegion
branch
from
5f20836
to
3c8310c
Compare
|
I fixed the repaint issues on main, so this patch can likely go in soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works, but it exposes a problem: scrolling of text (ls -l on a large directory) will redraw the text on top of the old text - this is caused by the
clear background that I allow using. So I need to account for that.
This sadly also brings back the ugly bar at the bottom, because the UIScrollView allows for over-scroll, and I do not seem to have a way of painting there. The solutions on StackOverflow include "Append a view underneat with the color that
you want" which is some ugly stuff. Will investigate later.