Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support $('#main').data('smoothState').reload() #363

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Cow258
Copy link

@Cow258 Cow258 commented Apr 29, 2018

Support Reload the page

$('#main').data('smoothState').reload();
//this like to this one
window.location.reload();

@@ -505,7 +505,30 @@
window.location = url;
}
},
/**Reload the page */
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably needs a docblock like all the others, just to keep to coding standards.

setRateLimitRepeatTime();

// clear cache
cache = {};
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if someone's cache has 4 or 5 entries, will this wipe the entire thing? Possible to search for the current location and remove only the one entry?


// Allows modifications to the request
request = options.alterRequest(request);
console.log(request);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this console.log just a leftover debug or intentional?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants