-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add site to examples of live sites with Smoothstate #308
Open
seangeng
wants to merge
84
commits into
update_readme
Choose a base branch
from
master
base: update_readme
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add sites built with ss.
Correct typos in README.md
Update the readme
Update the readme
typo in README.md
…rs and options.forms values too allow these selectors to be empty.
Check for falsey values of options.achors and options.forms
Added rate limiting to the SmoothState.clickAnchor() to prevent double-clicks from creating extra history states. Added option.clickAnchorRepeatDelay to specify the number if milliseconds until the next click will pass into the handler.
…se excess actions of either type would produce extra unwanted history states.
….jshintrc because of SmoothState.load.responses.loaded becoming too complex. I wasn't sure how you would want to refactor this so I could just gulp the library and send you another PR. Possible patch for issue #189 (#189). Added an additional optional argument to SmoothState.load() (cacheResponse) to control whether the loaded value would stay in the cache or not. Added a new option, options.allowFormCaching to control whather or not forms are cached set to false by default as caching forms can lead t some unusual behaviour as per #189). Updated SmoothState.formSubmit() to pass options.allowFormCaching into SmoothState.load() to determine if the cache should be used. Updated README.md to accommodate options.allowFormCaching.
Modified SmoothState.storePageIn() to collect all of the passed HTML elements under an <html> tag before using jQuery.find() to look for elements at any level of depth.
Fix repositionWindow
…n proposed in #199. Separated cache clear() call into one that occurs when the load() callback has already ended, and a another that will be called instead upon the callback ending if it has not yet.
Conflicts: jquery.smoothState.min.js
…cache length 0, smoothState wouls still act as though it had a cache length of 1. Clearing the cache for being over capacity BEFORE testing the contents of the cache resolves this issue and eliminates caching entirely for cache length 0.
Submitting PR again because I don't believe the CI test results...
- demonstrates smoothState plug-in on sidebar navigation - css, js and images are placed inside assets folder - demo-relevant.css defines layout and animation, while - main.js defines the behaviour of a smoothState library
added new demo to the demo folder
onPopState uses global event variable instead of event argument.
Update NPM + Cleanup Demos + Fixes
BindPrefetchHandlers
Fix popstate event event variable
Added support for redirected requests
Also I'd like to add other project(s): https://github.com/struts3/what-demos |
There is a small typo in src/jquery.smoothState.js. Should read `this` rather than `thid`.
docs: Fix simple typo, thid -> this
Would love to add https://askweedipedia.com to new live sites examples. |
Would love to add https://cozmiccali.com/ to new live sites examples. |
Would love to add https://cdcaosce.com/ to new live sites examples. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would love to add https://www.smokecartel.com to new live sites examples.