Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for file uploads #240

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mvdstam
Copy link

@mvdstam mvdstam commented Jan 7, 2016

No description provided.

@miguel-perez
Copy link
Owner

@mvdstam looks like this is not passing the tests and likely introducing a regression. Can you take a look?

@mvdstam
Copy link
Author

mvdstam commented Jan 14, 2016

Hey @miguel-perez!

Not really sure why your tests are failing:

  line 653  col 31  'request' is already defined.
  line 661  col 15  'request' used out of scope.
  line 661  col 46  'request' used out of scope.
  line 663  col 19  'request' used out of scope.
  line 664  col 17  'request' used out of scope.
  line 664  col 31  'request' used out of scope.
  line 664  col 51  'request' used out of scope.
  line 670  col 20  'request' used out of scope.
  line 653  col 23  'request' is defined but never used.

Looks like the tests don't understand the whole if/else situation in that particular block. Also: how could line 653 ever have tested green, since I haven't touched that line at all?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants