Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change cchardet to faust-cchardet #26

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Change cchardet to faust-cchardet #26

wants to merge 2 commits into from

Conversation

wbarnha
Copy link

@wbarnha wbarnha commented Jan 13, 2023

The original package is no longer maintained- you may want to switch over to my fork when I finish adding wheels for ARM macOS and Windows.

@wbarnha
Change cchardet to faust-cchardet
74836a5 
The original package is no longer maintained- you may want to switch over to my fork when I finish adding wheels for ARM macOS and Windows.
@wbarnha
Copy link
Author

wbarnha commented Jan 14, 2023 •
edited
Loading

On further research, ARM support for GitHub runners won't be available for a bit. Plus nobody seems to have ever created a uchardet.lib file which is blocking my support for Windows.

I legitimately am at a loss as to how the original project was able to build wheels for Windows. Something happened with the setup of the internal CI for WIndows runners to behave differently after some update...

@wbarnha wbarnha marked this pull request as draft January 14, 2023 16:19
@wbarnha wbarnha marked this pull request as ready for review January 14, 2023 20:40
@StayBlue
Copy link
Contributor

On further research, ARM support for GitHub runners won't be available for a bit. Plus nobody seems to have ever created a uchardet.lib file which is blocking my support for Windows.

I legitimately am at a loss as to how the original project was able to build wheels for Windows. Something happened with the setup of the internal CI for WIndows runners to behave differently after some update...

The project uses an older version of Python which still works fine to install the unmaintained version of cchardet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wbarnha @StayBlue