refactor: top statistics scraping #228
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just add an image url to the first player of each stat category to match with the pattern "teamId-playerImageId.webp". depends on: scraping players 12 and players in teams
nightmir3
changed the title
nightmir3
changed the title
|
Hey @nightmir3 🏄♂️ You could use the style guidelines for commits (also title) from the CONTRIBUTING.md file ? Thank you! examples of some commits and titles:
|
nightmir3
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scrape top stats page for the first player image
just add an image url to the first player of each stat category to match with the pattern "teamId-playerImageId.webp".
depends on:
scraping players 12 and players in teams