Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/proxy and split #473

Merged
merged 58 commits into from
Jan 25, 2024
Merged

feature/proxy and split #473

merged 58 commits into from
Jan 25, 2024

Conversation

baywet
Copy link
Member

@baywet baywet commented Jan 19, 2024 •
edited
Loading

depends on microsoft/kiota-typescript#993
TODO:

  • reinstall the kiota modules for all graph packages

@baywet baywet self-assigned this Jan 19, 2024
@baywet baywet mentioned this pull request Jan 19, 2024
Merged
baywet added 28 commits January 23, 2024 15:16
@baywet
- removes dependency on core client
fbeed4b
@baywet
- initial proxy generation
de1eea5
@baywet
- moves everything to a temporary migration directory
7c8b4fe
@baywet
- removes all generated code
763f023
@baywet
- lerna init
2ada3dd
@baywet
- adds main package
ba10887
@baywet
- restores configuration files
37f66c1
@baywet
- adds main package dependencies
4c6cd0c
@baywet
- moves tests to a temproary migration directory as the main lib does…
9ff23a1 
…n't have a client anymore
@baywet
- code-gen: models
2256602
@baywet
- updates main export
a91af10
@baywet
- adds app catalog package
bb8354d
@baywet
- moves generated code at the root
94eb641
@baywet
- adds modular augmentation of the client
e76103f 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- replaces local reference to model package
86e649f
@baywet
- adds configuration from kiota typescript
7e01874
@baywet
- fixes root dir for transpilation
a72e8db
@baywet
- hack cleanup
dabfe18 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- moves graph service client to dedicated file
09a6ebe 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- removes src from import paths
1baec61 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- moves main package to root
2447d9e
@baywet
- moves fluent api for app catalogs to the root
0e7eea3 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- adds base configuration for packages
2280245 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- fixes appcatalogs package configuration
05342d1 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- adds admin package shell
0365268 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- code-gen: admin path
6d8df57 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
- fixes modular augmentation
7b5982b
@baywet
- adds some duplication so two APIs can be consumed
ea8edd3 
Signed-off-by: Vincent Biret <[email protected]>
andrueastman
andrueastman reviewed Jan 24, 2024
View reviewed changes
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments on this side

  • The test step in the CI seems to be failing for the /msgraph-sdk-javascript-tests
  • The properties in the individual package.json for author,description need updating

@baywet baywet requested a review from andrueastman January 24, 2024 14:58
@baywet baywet disabled auto-merge January 24, 2024 15:47
@baywet baywet enabled auto-merge January 24, 2024 16:27
@baywet baywet merged commit 994abdd into dev Jan 25, 2024
10 checks passed
@baywet baywet deleted the feature/proxy-and-split branch January 25, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman approved these changes

Assignees

@baywet baywet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baywet @andrueastman