Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat(generation): update request builders and models (#786)" #788

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

rkodev
Copy link
Contributor

@rkodev rkodev commented Oct 15, 2024

This reverts commit ddd28a4.

Overview

Brief description of what this PR does.

Demo

Optional. Screenshots, examples, etc.

Notes

Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.

Testing Instructions

  • How to test this PR
  • Prefer bulleted description
  • Start after checking out this branch
  • Include any setup required, such as bundling scripts, restarting services, etc.
  • Include test case, and expected output

@rkodev rkodev requested a review from a team as a code owner October 15, 2024 17:59
@baywet
Copy link
Member

baywet commented Oct 15, 2024

@rkodev can you provide some more context on what's happening here please?

@rkodev
Copy link
Contributor Author

rkodev commented Oct 15, 2024

@baywet Missed an update on the issue with the metadata generation. Reverting the merged commit

@baywet
Copy link
Member

baywet commented Oct 15, 2024

@rkodev as a general practice, please detail those things out so others can follow along :) Don't hesitate to link to an upstream metadata issue as well. We've had cross language communication issues in the past. Going to other languages PRs to flag a potential metadata issue is always appreciated.

@rkodev
Copy link
Contributor Author

rkodev commented Oct 16, 2024

@baywet Here is the metadata issue that caused the issue with generation

@rkodev rkodev merged commit d5645b8 into main Oct 16, 2024
6 checks passed
@rkodev rkodev deleted the revert-786-v1.0/pipelinebuild/167170 branch October 16, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants