Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds changeType custom query option to delta function for messages #500

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

irvinesunday
Copy link
Contributor

Fixes #480

@irvinesunday irvinesunday self-assigned this Nov 15, 2023
@irvinesunday irvinesunday requested a review from a team as a code owner November 15, 2023 16:44
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick trunaround

<Record>
<PropertyValue Property="Name" String="changeType" />
<PropertyValue Property="Description" String="A custom query option to filter the delta response based on the type of change. Supported values are created, updated or deleted." />
<PropertyValue Property="Required" Bool="true" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@irvinesunday I believe the "required" property here should be false as its not mandatory to pass this query parameter.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must have misinterpreted this statement:

image

I will push a PR to resolve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mail Message Delta list missing change type query parameter
3 participants