Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update with new Store certificate #5140

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

JohnMcPMS
Copy link
Member

@JohnMcPMS JohnMcPMS commented Jan 15, 2025

Change

Rotate the new Store certificate in and the old one out.

Microsoft Reviewers: Open in CodeFlow

@JohnMcPMS JohnMcPMS requested a review from a team as a code owner January 15, 2025 20:02
@yao-msft
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yao-msft
Copy link
Contributor

I don't think we addressed this yet? #3435
Either we swap the cert1 and cert 2 to delay the test errors Or we'll do the real fix before cert2 expires.

@JohnMcPMS
Copy link
Member Author

I don't think we addressed this yet? #3435 Either we swap the cert1 and cert 2 to delay the test errors Or we'll do the real fix before cert2 expires.

I always rotate Leaf2 to Leaf1 and make the new certificate Leaf2. While we should fix that issue, I think it is fairly low priority. If we ever stop updating the pinning certificates, we also probably stopped supporting the product generally.

@JohnMcPMS JohnMcPMS merged commit 34a3363 into microsoft:master Jan 16, 2025
9 checks passed
@JohnMcPMS JohnMcPMS deleted the update-certs branch January 16, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants