Harden reg-free class activation #3365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about the |
|
After reflecting on it more ☕... I suppose if I ask you to grab the meat from the fridge and you check, only to find it empty, that should conclude the task. I wouldn't want you searching elsewhere or making assumptions about where else it might be. Looks good to me. |
riverar
approved these changes
Dec 9, 2024
|
Yes, this ensures that it does not accidentally "fall through" and attempt reg-free when activation should legitimately fail for one reason or another. This is a simplified version of what's being done here for cppwinrt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reg-free activation should only be attempted if the class is not registered.
It should not be attempted if the class is registered but fails to activate.
Fixes: #3339