Improve sample binary build dependencies #3191
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
But of course, that doesn't work since the yml tests are executed with an explicit target which means that Cargo doesn't use the default target location for binaries, a further reminder of how poorly binaries are supported in Cargo. 😢 rust-lang/cargo#9661 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Binary crate dependencies continue to be a weak point in Cargo. This just attempts to make the binary component samples build a little bit more reliably. In these two cases, the dependent (client) crates need the component (server) crates built ahead of their build scripts as it relies on the component to produce the .winmd files that the build scripts use to generate bindings.