-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Derive Copy
, Clone
, and Debug
for handles
#3015
Conversation
Both #3015 and #3016 are failing with this GNU dlltool error: https://github.com/microsoft/windows-rs/actions/runs/8924805385/job/24511973178?pr=3015 Unrelated to this change I believe. Any idea what this might be about? Perhaps a change to the GitHub runners? |
Looks like GHA runners have changed somehow:
32-bit dlltool cannot create x86_64 import libraries. |
Looping in @mati865 for awareness, as they have some dlltool work in the pipe rust-lang/rust#124138. Oops, same person. Still investigating what's going on here, was working few nights ago. Nightly bug? |
This comment was marked as outdated.
This comment was marked as outdated.
On the second thought, failing test runs on x86_64 host but targets i686. But it's a proc macro so it should still build for the host. It could really be a regression then. |
We manually prepend |
Ah, makes sense then. Previous success doesn't make sense though 😄 It'd probably work if you set PATH to |
Should handle types also |
Note that this PR isn't adding these traits - it's merely deriving them rather than generating them directly. |
This just reduces code gen and improves readability.