Add non-windows support for PWSTR and PCWSTR #3004
Merged
+59
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree company="Princh" |
|
This does not fix #1874 which is asking for 32-bit wide string support, which is a good example of why I am reluctant to expand support for non-Windows targets. Supporting non-Windows platforms involves much more than merely avoiding this one call to |
Merged
|
You can use #3005 for test coverage. |
kennykerr
reviewed
Apr 19, 2024
tyilo
force-pushed
the
non-windows-pwstr
branch
from
c4b30b9 to
b3833cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #2996,
PWSTRandPCWSTRcurrently has undocumented undefined behaviour in theas_widemethod.This fixes this by using a different implementation on non-windows targets.
Fixes: #2996, #1874