Fix generic class signature calculation #2927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WinRT classes include the default interface signature as part of their SHA1 signature. Usually this is just the signature of the interface's GUID, however when the interface is generic this signature is the signature of the generic type itself. To keep things generic, I opted to generate
RuntimeTypeimplementations for all WinRT interfaces. This avoids having to special-case such classes. Previously, I only included implementations for non-exclusive interfaces.Fixes: #2922
Previously this was calculated correctly, but #2729 broke this edge case. This PR also adds a test case to ensure future optimizations don't break this calculation. Thanks to @riverar for tracking down the offending PR.