Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary std usage from bindgen in writer.rs #2757

Conversation

ajw221
Copy link

@ajw221 ajw221 commented Dec 26, 2023

Recently ran into some issues while attempting to use windows-bindgen in a no_std crate. The generated code contains almost all ::core usage except for a few areas where ::std is used instead.

@ajw221
Copy link
Author

ajw221 commented Dec 26, 2023

@microsoft-github-policy-service agree

@microsoft-github-policy-service agree

@kennykerr
Copy link
Collaborator

Maybe we need a dedicated test crate that "proves" this works for no_std to avoid future regressions, unless all of test_standalone can be marked no_std.

@kennykerr
Copy link
Collaborator

This would also depend on the windows-core being no_std. While I think this is a good idea in general, this will require a bit more of a systematic approach. Why don't you start by creating an issue and we can discuss.

@kennykerr kennykerr closed this Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants