Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing NotifyIcon notification constant #1769

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add missing NotifyIcon notification constant #1769

wants to merge 3 commits into from

Conversation

riverar
Copy link
Collaborator

@riverar riverar commented Dec 18, 2023 •
edited
Loading

Fixes: #1765

@mikebattista
Copy link
Collaborator

What's blocking it from being int?

@riverar
Copy link
Collaborator Author

riverar commented Dec 18, 2023

@mikebattista I didn't fully explore that rabbit hole, but I think we'll need to change WM_USER and all the NIN_ msgs to int and then fix all the collateral damage. 😅

@riverar
Copy link
Collaborator Author

riverar commented Dec 18, 2023

Interesting, made the change locally again and doesn't seem as bad. Will update this PR shortly.

@riverar riverar marked this pull request as draft December 18, 2023 19:48
@riverar riverar marked this pull request as ready for review December 18, 2023 21:20
@riverar
Copy link
Collaborator Author

riverar commented Dec 18, 2023

Looks like AzDO has given up on builds. @mikebattista

@mikebattista
Copy link
Collaborator

All the other WM_ constants are uint. Are there side effects of making WM_USER int but not the others? Feels like this should cause some usability problems somewhere.

@riverar
Copy link
Collaborator Author

riverar commented Dec 18, 2023

Yeah, I think there's a larger "naked constants should default to int not uint" discussion to be had here.

@mikebattista
Copy link
Collaborator

Looks like AzDO has given up on builds. @mikebattista

Thanks. I believe it should be fixed now.

@riverar riverar force-pushed the rafael/notifyicon_msgs branch from 01f35c4 to 579cc3e Compare May 3, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikebattista mikebattista Awaiting requested review from mikebattista mikebattista is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NIN_KEYSELECT missing
2 participants
@riverar @mikebattista