Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to walkthrough #23107

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Updates to walkthrough #23107

merged 2 commits into from
Mar 22, 2024

Conversation

cwebster-99
Copy link
Member

@cwebster-99 cwebster-99 added experimenting Feature is part of an experiment debt Covers everything internal: CI, testing, refactoring of the codebase, etc. area-editor-* User-facing catch-all skip package*.json package.json and package-lock.json don't both need updating labels Mar 21, 2024
@cwebster-99 cwebster-99 requested a review from luabud March 21, 2024 14:14
@cwebster-99 cwebster-99 added the skip tests Updates to tests unnecessary label Mar 21, 2024
luabud
luabud approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@luabud luabud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you :)

@cwebster-99 cwebster-99 merged commit 225fce3 into main Mar 22, 2024
63 checks passed
@cwebster-99 cwebster-99 deleted the remote-donkey branch March 22, 2024 13:49
wesm pushed a commit to posit-dev/positron that referenced this pull request Apr 5, 2024
@cwebster-99 @eleanorjboyd @wesm
Updates to walkthrough (microsoft/vscode-python#23107)
82e8fec 
- Updating walkthrough based on previous experiment
- Updating based on
microsoft/vscode-python#22664

Co-authored-by: Eleanor Boyd <[email protected]>
wesm pushed a commit to posit-dev/positron that referenced this pull request Apr 8, 2024
@cwebster-99 @eleanorjboyd @wesm
Updates to walkthrough (microsoft/vscode-python#23107)
69fa364 
- Updating walkthrough based on previous experiment
- Updating based on
microsoft/vscode-python#22664

Co-authored-by: Eleanor Boyd <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luabud luabud luabud approved these changes

Assignees

@cwebster-99 cwebster-99

Labels
area-editor-* User-facing catch-all debt Covers everything internal: CI, testing, refactoring of the codebase, etc. experimenting Feature is part of an experiment skip package*.json package.json and package-lock.json don't both need updating skip tests Updates to tests unnecessary
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cwebster-99 @luabud @eleanorjboyd