Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove new line chars from error text messages in testing rewrite #22402

Merged
merged 1 commit into from
Nov 2, 2023
Merged

remove new line chars from error text messages in testing rewrite #22402

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/client/testing/testController/common/resultResolver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ export class PythonResultResolver implements ITestResultResolver {
}).join('\r\n');
const text = `${testItem.test} failed with error: ${
testItem.message ?? testItem.outcome
}\r\n${traceback}\r\n`;
}\r\n${traceback}`;
const message = new TestMessage(text);

const grabVSid = this.runIdToVSid.get(keyTemp);
Expand All @@ -173,7 +173,7 @@ export class PythonResultResolver implements ITestResultResolver {
removeEmptyEntries: true,
}).join('\r\n');

const text = `${testItem.test} failed: ${testItem.message ?? testItem.outcome}\r\n${traceback}\r\n`;
const text = `${testItem.test} failed: ${testItem.message ?? testItem.outcome}\r\n${traceback}`;
const message = new TestMessage(text);

// note that keyTemp is a runId for unittest library...
Expand Down Expand Up @@ -235,7 +235,7 @@ export class PythonResultResolver implements ITestResultResolver {
const traceback = data.traceback ?? '';
const text = `${data.subtest} failed: ${
testItem.message ?? testItem.outcome
}\r\n${traceback}\r\n`;
}\r\n${traceback}`;
parentTestItem.children.add(subTestItem);
runInstance.started(subTestItem);
const message = new TestMessage(text);
Expand Down
Loading