Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove isort support #22187

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Remove isort support #22187

merged 1 commit into from
Oct 10, 2023

Conversation

karthiknadig
Copy link
Member

@karthiknadig karthiknadig commented Oct 10, 2023 •
edited
Loading

This feature is now moved to ms-python.isort extension.

For #22183
Closes #22147

@karthiknadig karthiknadig added the feature-request Request for new features or functionality label Oct 10, 2023
@karthiknadig karthiknadig self-assigned this Oct 10, 2023
@karthiknadig karthiknadig removed the request for review from paulacamargo25 October 10, 2023 00:07
@karthiknadig karthiknadig added the skip package*.json package.json and package-lock.json don't both need updating label Oct 10, 2023
@karthiknadig karthiknadig marked this pull request as ready for review October 10, 2023 01:01
@karthiknadig karthiknadig enabled auto-merge (squash) October 10, 2023 01:02
@karthiknadig karthiknadig merged commit 92c2a2f into microsoft:main Oct 10, 2023
31 of 33 checks passed
@karthiknadig karthiknadig deleted the remove-sort branch October 30, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonykim1 anthonykim1 anthonykim1 approved these changes

@eleanorjboyd eleanorjboyd Awaiting requested review from eleanorjboyd

Assignees

@karthiknadig karthiknadig

Labels
feature-request Request for new features or functionality skip package*.json package.json and package-lock.json don't both need updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sort Imports not working
2 participants
@karthiknadig @anthonykim1