Skip to content

Commit

Permalink
Remove star from recommended (#22759)
Browse files Browse the repository at this point in the history
  • Loading branch information
karthiknadig authored Jan 17, 2024
1 parent b09848c commit baea7a1
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,6 @@ export class SetInterpreterCommand extends BaseInterpreterSelectorCommand implem
}
const areItemsGrouped = items.find((item) => isSeparatorItem(item) && item.label === EnvGroups.Recommended);
const recommended = cloneDeep(suggestion);
recommended.label = `${Octicons.Star} ${recommended.label}`;
recommended.description = areItemsGrouped
? // No need to add a tag as "Recommended" group already exists.
recommended.description
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ suite('Set Interpreter Command', () => {
const state: InterpreterStateArgs = { path: 'some path', workspace: undefined };
const multiStepInput = TypeMoq.Mock.ofType<IMultiStepInput<InterpreterStateArgs>>();
const recommended = cloneDeep(item);
recommended.label = `${Octicons.Star} ${item.label}`;
recommended.label = item.label;
recommended.description = interpreterPath;
const suggestions = [
expectedEnterInterpreterPathSuggestion,
Expand Down Expand Up @@ -287,7 +287,7 @@ suite('Set Interpreter Command', () => {
const state: InterpreterStateArgs = { path: 'some path', workspace: undefined };
const multiStepInput = TypeMoq.Mock.ofType<IMultiStepInput<InterpreterStateArgs>>();
const recommended = cloneDeep(item);
recommended.label = `${Octicons.Star} ${item.label}`;
recommended.label = item.label;
recommended.description = interpreterPath;
const suggestions = [
expectedCreateEnvSuggestion,
Expand Down Expand Up @@ -496,7 +496,7 @@ suite('Set Interpreter Command', () => {
.setup((i) => i.getRecommendedSuggestion(TypeMoq.It.isAny(), TypeMoq.It.isAny()))
.returns(() => item);
const recommended = cloneDeep(item);
recommended.label = `${Octicons.Star} ${item.label}`;
recommended.label = item.label;
recommended.description = interpreterPath;
const suggestions = [
expectedEnterInterpreterPathSuggestion,
Expand Down Expand Up @@ -613,7 +613,7 @@ suite('Set Interpreter Command', () => {
.setup((i) => i.getRecommendedSuggestion(TypeMoq.It.isAny(), TypeMoq.It.isAny()))
.returns(() => item);
const recommended = cloneDeep(item);
recommended.label = `${Octicons.Star} ${item.label}`;
recommended.label = item.label;
recommended.description = interpreterPath;
const suggestions = [
expectedEnterInterpreterPathSuggestion,
Expand Down Expand Up @@ -703,7 +703,7 @@ suite('Set Interpreter Command', () => {
const state: InterpreterStateArgs = { path: 'some path', workspace: undefined };
const multiStepInput = TypeMoq.Mock.ofType<IMultiStepInput<InterpreterStateArgs>>();
const recommended = cloneDeep(item);
recommended.label = `${Octicons.Star} ${item.label}`;
recommended.label = item.label;
recommended.description = interpreterPath;
const separator = { label: EnvGroups.Recommended, kind: QuickPickItemKind.Separator };

Expand Down Expand Up @@ -854,7 +854,7 @@ suite('Set Interpreter Command', () => {
await sleep(1);

const recommended = cloneDeep(refreshedItem);
recommended.label = `${Octicons.Star} ${refreshedItem.label}`;
recommended.label = refreshedItem.label;
recommended.description = `${interpreterPath} - ${Common.recommended}`;
assert.deepStrictEqual(
quickPick,
Expand Down

0 comments on commit baea7a1

Please sign in to comment.