fix - Show error message when test runner finishes (#1713)

microsoft · Jul 22, 2024 · e78dc4a · e78dc4a
1 parent f86932f
commit e78dc4a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/src/controller/testController.ts b/src/controller/testController.ts
@@ -362,11 +362,14 @@ async function executeWithTestRunner(option: IRunOption, testRunner: TestRunner,
             }
         }));
 
-        disposables.push(testRunner.onDidFinishTestRun((_event: TestFinishEvent) => {
+        disposables.push(testRunner.onDidFinishTestRun((event: TestFinishEvent) => {
+            if (event.statusCode !== 0) {
+                window.showErrorMessage(event.message ?? 'Failed to run tests.');
+            }
             return resolve();
         }));
 
-        testRunner.launch(testContext);
+        await testRunner.launch(testContext);
     });
 
     function findTestClass(parts: TestIdParts): TestItem {

diff --git a/src/java-test-runner.api.ts b/src/java-test-runner.api.ts
@@ -54,10 +54,10 @@ export interface TestIdParts {
  */
 export interface TestRunner {
     /**
-     * launch test test execution.
+     * launch the test execution.
      * @param context the context for this test run.
      */
-    launch(context: IRunTestContext): void;
+    launch(context: IRunTestContext): vscode.ProviderResult<void>;
 
     /**
      * Event that should be emitted when the status of a test item changes.