Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bun support as a package manager #475

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kravetsone
Copy link

@kravetsone kravetsone commented Jun 2, 2024

Description

This PR adds support for bun as a package manager.

Changes

Based on the existing tests, I've created additional tests to validate support for bun with all relevant templates.

Checklist

@kravetsone
Copy link
Author

@kravetsone please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@aeschli
Copy link
Contributor

aeschli commented Jun 4, 2024

Please check with us first if we want a feature, before investing work in a PR that we might not take.

I haven't used bun myself, but from what I read, it's most of all a new runtime, that also comes with a package manager. Isn't it confusing to use bun as package manager when the runtime is NodeJS?
Note that the yo code generator is mostly for new users. and we want to keep things as simple as possible.

If all that's needed is to replace npm with bun, that's quite easy to do with find/replace. No need to make the yo code generator more complex.

@kravetsone
Copy link
Author

Isn't it confusing to use bun as package manager when the runtime is NodeJS?

I don't think so. Bun as a package manager only is already used in a huge number of repositories.

Why shouldn't he be on the list? Who knows, he will choose. Moreover, yoeman is now execute bun install (but the release has not yet been released)

No need to make the yo code generator more complex.

Does that make it harder? The usual choice is the same as between npm/yarn/pnpm...

@kravetsone
Copy link
Author

yeoman/[email protected] with Bun install released.

Do I need to bump the version in dependencies?

@kravetsone kravetsone marked this pull request as ready for review June 10, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants