Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libtorch] Include <chrono> for high_resolution_clock #43234

Merged

Conversation

LilyWangLL
Copy link
Contributor

Due to there are new changes merged by microsoft/STL#5105, so port libtorch need to include <chrono> by patching to fix the following error:

D:\b\libtorch\src\v2.1.2-48aa56738d.clean\torch/csrc/jit/runtime/logging.h(60): error C2039: 'high_resolution_clock': is not a member of 'std::chrono'
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.42.34433\include\__msvc_chrono.hpp(286): note: see declaration of 'std::chrono'
D:\b\libtorch\src\v2.1.2-48aa56738d.clean\torch/csrc/jit/runtime/logging.h(60): error C2065: 'high_resolution_clock': undeclared identifier

Upstream has been fix this issue in pytorch/pytorch@4d0386c.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Sorry, something went wrong.

@LilyWangLL LilyWangLL added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jan 13, 2025
@LilyWangLL LilyWangLL marked this pull request as ready for review January 14, 2025 01:51
@LilyWangLL LilyWangLL requested a review from jimwang118 January 15, 2025 02:44
@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Jan 15, 2025
@vicroms vicroms merged commit e1118ae into microsoft:master Jan 15, 2025
17 checks passed
@LilyWangLL LilyWangLL deleted the dev/LilyWang/include-chrono-libtorch branch January 16, 2025 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants