Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[librtmp] Update to 2024-03-01 #43197

Merged
merged 2 commits into from
Jan 14, 2025
Merged

[librtmp] Update to 2024-03-01 #43197

merged 2 commits into from
Jan 14, 2025

Conversation

paperchalice
Copy link
Contributor

@paperchalice paperchalice commented Jan 10, 2025

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory. OpenSSL issues are fixed by upstream.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

  • Use the latest commit (2.6).
  • Provide pkgconfig file, so curl can consume it. (May open another PR to add it.)
  • Rename target librtmp to rtmp so pkg-config can work correctly.
  • Use vcpkg zlib in librtmp.pc.

@paperchalice paperchalice changed the title [librtmp] 2024-03-01 [librtmp] Update to 2024-03-01 Jan 10, 2025
@Cheney-W Cheney-W added the category:port-update The issue is with a library, which is requesting update new revision label Jan 13, 2025
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Jan 13, 2025
@Cheney-W
Copy link
Contributor

Usage test pass with following command:

find_package(PkgConfig REQUIRED)
pkg_check_modules(librtmp REQUIRED IMPORTED_TARGET librtmp)
target_link_libraries(main PkgConfig::librtmp)

@vicroms vicroms merged commit 55e01fc into microsoft:master Jan 14, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants