Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[marchingcubecpp] New port #43195

Merged
merged 1 commit into from
Jan 12, 2025
Merged

Conversation

talregev
Copy link
Contributor

@talregev talregev commented Jan 10, 2025

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

Not found on https://repology.org/
This port is needed for mujoco:
https://github.com/google-deepmind/mujoco/blob/main/cmake/MujocoDependencies.cmake#L116

@LilyWangLL LilyWangLL added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jan 10, 2025
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Jan 10, 2025
Copy link
Member

@vicroms vicroms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Header files should be installed in a sub-directory.

ports/marchingcubecpp/portfile.cmake Outdated Show resolved Hide resolved
ports/marchingcubecpp/portfile.cmake Outdated Show resolved Hide resolved
ports/marchingcubecpp/portfile.cmake Show resolved Hide resolved
@vicroms vicroms marked this pull request as draft January 11, 2025 20:15
@talregev talregev force-pushed the TalR/marchingcubecpp branch from 21d2c17 to 7f2cd75 Compare January 12, 2025 09:09
@talregev talregev marked this pull request as ready for review January 12, 2025 09:09
@talregev
Copy link
Contributor Author

@vicroms @LilyWangLL
The port is ready for review.

Signed-off-by: Tal Regev <[email protected]>
@talregev talregev force-pushed the TalR/marchingcubecpp branch from 7f2cd75 to 3e34cde Compare January 12, 2025 09:11
@talregev talregev requested a review from vicroms January 12, 2025 09:16
@vicroms vicroms merged commit d7112d1 into microsoft:master Jan 12, 2025
17 checks passed
@talregev talregev deleted the TalR/marchingcubecpp branch January 14, 2025 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants