[sdl2] Fix could not find found library alsa #42964
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WangWeiLin-MV
added
category:port-bug
dg0yt
reviewed
Dec 27, 2024
|
|
||
| set(SDL_ALSA @SDL_ALSA@) | ||
| set(SDL_ALSA_SHARED @SDL_ALSA_SHARED@) | ||
| -if(SDL_ALSA AND NOT SDL_ALSA_SHARED AND TARGET SDL2::SDL2-static) | ||
| +if(SDL_ALSA) | ||
| + set(CMAKE_REQUIRE_FIND_PACKAGE_ALSA 1) |
There was a problem hiding this comment.
This doesn't make sense. If the user asks for alsa, and the dependency alsa is installed, then CMAKE_REQUIRE_FIND_PACKAGE_ALSA doesn't cause an error, but it catches errors.
There was a problem hiding this comment.
It can be reproduced by find_package(SDL2 CONFIG REQUIRED) twice.
find_package(SDL2 CONFIG REQUIRED)
find_package(SDL2 CONFIG REQUIRED)There was a problem hiding this comment.
Can be reproduced with find_package(ALSA). Fix in #43008.
|
Wait fix in #42912 |
WangWeiLin-MV
added
the
depends:different-pr
dg0yt
suggested changes
Dec 30, 2024
WangWeiLin-MV
removed
the
depends:different-pr
|
Fixed at fa643c3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #42929, error with
Could NOT find ALSA (missing: ALSA_LIBRARY) (found version "1.2.13")Remove
set(CMAKE_REQUIRE_FIND_PACKAGE_ALSA 1).Checklist
./vcpkg x-add-version --alland committing the result.Test
The installation
vcpkg install sdl2[alsa] imgui[sdl2-binding,sdl2-renderer-binding]tests pass with the following triplets: