[libb2] Fix Windows build #42925
Closed
[libb2] Fix Windows build #42925
+47
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paperchalice
force-pushed
the
libb2
branch
2 times, most recently
from
310ae2d to
54a15bc
Compare
jimwang118
added
the
category:port-bug
|
It is recommended that the patches be submitted to the upstream at the same time, and the upstream will adapt to Windows when the version is updated later. |
dg0yt
reviewed
Dec 26, 2024
Comment on lines
+13
to
+15
| set(pre_run PRERUN_SHELL | ||
| "sed -i 's/cross_compiling=yes/cross_compiling=no/g' configure" | ||
| ) |
There was a problem hiding this comment.
This can be done in the portfile with vcpkg_replace_string, but...
... changing configure before AUTOCONFIG is pointless.
There was a problem hiding this comment.
libb2 doesn't ship configure in release tarball... and I coudn't fix error in configure when cross compile from x64 to x86 in CI, although it works fine in may local machine.
There was a problem hiding this comment.
Enabling Windows without patch in #42952.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./vcpkg x-add-version --alland committing the result.