Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[folly related] update to 10.21 #41805

Merged
merged 4 commits into from
Oct 31, 2024
Merged

[folly related] update to 10.21 #41805

merged 4 commits into from
Oct 31, 2024

Conversation

c8ef
Copy link
Contributor

@c8ef c8ef commented Oct 27, 2024 •
edited
Loading

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@WangWeiLin-MV WangWeiLin-MV added the category:port-update The issue is with a library, which is requesting update new revision label Oct 28, 2024
WangWeiLin-MV
WangWeiLin-MV previously approved these changes Oct 28, 2024
View reviewed changes
@BillyONeal
Copy link
Member

/azp run

1 similar comment
@BillyONeal
Copy link
Member

/azp run

@vicroms vicroms closed this Oct 28, 2024
@vicroms vicroms reopened this Oct 28, 2024
@c8ef c8ef closed this Oct 28, 2024
@c8ef c8ef reopened this Oct 28, 2024
@c8ef
Copy link
Contributor Author

c8ef commented Oct 29, 2024

I'm not sure why the CI failed during checkout. Do I need to modify this patch, or is there still an issue with the CI? @BillyONeal

@WangWeiLin-MV WangWeiLin-MV reopened this Oct 29, 2024
@WangWeiLin-MV
Copy link
Contributor

/azp run

1 similar comment
@WangWeiLin-MV
Copy link
Contributor

/azp run

@WangWeiLin-MV WangWeiLin-MV added the info:reviewed Pull Request changes follow basic guidelines label Oct 29, 2024
@BillyONeal
Copy link
Member

I believe all the problems that were experienced with PR Build here were the result of https://status.dev.azure.com/_event/559260722

vicroms
vicroms previously approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@vicroms vicroms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, please fix the file conflict so we can get them merged.

@c8ef c8ef dismissed stale reviews from vicroms and WangWeiLin-MV via dda0348 October 30, 2024 01:25
@c8ef c8ef requested review from vicroms and WangWeiLin-MV October 30, 2024 01:27
@c8ef
Copy link
Contributor Author

c8ef commented Oct 31, 2024

Ping. @vicroms

@vicroms vicroms merged commit e6cedc7 into microsoft:master Oct 31, 2024
16 checks passed
@c8ef c8ef deleted the folly branch October 31, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WangWeiLin-MV WangWeiLin-MV WangWeiLin-MV approved these changes

@vicroms vicroms Awaiting requested review from vicroms

Assignees

@WangWeiLin-MV WangWeiLin-MV

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@c8ef @BillyONeal @WangWeiLin-MV @vicroms