[vcpkg scripts] enable patchelf on windows for cross-compiling toolchains #41578
Conversation
| if(CMAKE_HOST_SYSTEM_NAME STREQUAL "Linux") | ||
| set(program_version 0.14.5) |
There was a problem hiding this comment.
Note for reviewers: the previous update attempt was in #31107 and no new releases happened after that.
There was a problem hiding this comment.
i didn't try any update for linux, this is the previous version confirmed.
the windows version (newer) is still untested, i am building the pipeline and upstreaming everything possible as soon as i can
|
/azp run |
|
Rerunning due to network mistake last night. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
JonLiu1993
changed the title
JonLiu1993
added
the
category:tool-update
| @@ -16,4 +16,15 @@ if(CMAKE_HOST_SYSTEM_NAME STREQUAL "Linux") | |||
| set(download_urls "https://github.com/NixOS/patchelf/releases/download/${program_version}/${download_filename}") | |||
| set(tool_subdirectory "${program_version}-${patchelf_platform}-linux") | |||
| set(paths_to_search "${DOWNLOADS}/tools/patchelf/${program_version}-${patchelf_platform}-linux/bin") | |||
| elseif(CMAKE_HOST_SYSTEM_NAME STREQUAL "Windows") | |||
| set(patchelf_host "win32") | |||
| set(program_version 0.18.0) | |||
There was a problem hiding this comment.
still better than erroring out because it's missing? i didn't update the linux version, i just added a windows one
There was a problem hiding this comment.
as a side note, there is no 0.14.5 version of patchelf for windows. The first version that was built for windows is 0.17.0, so since I had to choose one, I went for the newest one
Add handling of patchelf on windows, in case of cross-compiling toolchains (e.g. arm linaro on windows)