-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rttr] Disable -Werror in order to support android #37406
Conversation
Regarding the precision of the values, they are well below the precision range of float(-2^128 ~ +2^128).
|
Precision is not min/max value. Precision is number of signifcant bits. It is relevant for floating point type which use part of the bits for the exponent. In addition, the ranges of int, float, and log are not defined exactly. Only the minimum range can be assumed for each type. Now the patched function is only to indicate if a value is too small or too large to fit into the floating point type. Maybe the patch is acceptable because precision is not an issue here. But correct transition between fp and integer can be tricky, and so it should be reviewed carefully. |
Add |
I'm not convinced that this patch is correct in the face of all types F and T. In particular, it's not necessarily true that I do not think it is appropriate to apply a change like this without upstream having made the change first. It is not clearly only build system related or similarly related to our core competencies, so I don't think even a waiting period is appropriate. If the actual build failure is due to some sort of warning that fires on Android, turning off the warning would be OK. |
Awesome, thanks! |
Fix #37123
Note:
In C++, if two values of different types are operated on or compared, the compiler attempts an implicit type conversion to convert one value to the type of the other. This implicit type conversion may result in loss of precision, overflow, or incorrect results。
Now change to the result of explicit conversion for android.
Upstream PR: rttrorg/rttr#371
SHA512s are updated for each updated download../vcpkg x-add-version --all
and committing the result.