Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tidy-html5] Replace uwp does not support functions #35375

Merged
merged 6 commits into from
Jan 30, 2024

Conversation

jimwang118
Copy link
Contributor

@jimwang118 jimwang118 commented Nov 28, 2023

Fixes #35249

Replace the api function lstrlen under windows with the C library function strlen.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Usage test pass with following triplets:

x64-windows
arm64-uwp

@jimwang118 jimwang118 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Nov 28, 2023
@jimwang118 jimwang118 marked this pull request as ready for review November 28, 2023 08:00
@Cheney-W Cheney-W marked this pull request as draft November 28, 2023 09:20
@jimwang118
Copy link
Contributor Author

Submitted an issue 1102 to the upstream and waited for the upstream's reply on the fix.

@jimwang118 jimwang118 marked this pull request as ready for review December 7, 2023 02:35
Cheney-W
Cheney-W previously approved these changes Dec 8, 2023
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Dec 8, 2023
@BillyONeal BillyONeal marked this pull request as draft December 8, 2023 09:29
@BillyONeal BillyONeal removed the info:reviewed Pull Request changes follow basic guidelines label Dec 8, 2023
@jimwang118 jimwang118 marked this pull request as ready for review January 29, 2024 08:48
@Cheney-W Cheney-W changed the title [tidy_html5] Replace uwp does not support functions [tidy-html5] Replace uwp does not support functions Jan 29, 2024
@Cheney-W Cheney-W marked this pull request as draft January 29, 2024 10:45
@jimwang118 jimwang118 marked this pull request as ready for review January 30, 2024 01:45
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Jan 30, 2024
@data-queue data-queue merged commit 98ee16b into microsoft:master Jan 30, 2024
16 checks passed
TomKatom pushed a commit to TomKatom/vcpkg that referenced this pull request Feb 23, 2024
* Replace uwp does not support functions

* update version

* fix patch

* update version

* del baseline

---------

Co-authored-by: Jim wang (BEYONDSOFT CONSULTING INC) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tidy-html5[core]:arm64-uwp Build failure
4 participants