Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add article: Authenticate to third-party services #420

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vicroms
Copy link
Member

@vicroms vicroms commented Oct 31, 2024

No description provided.

Copy link
Contributor

Learn Build status updates of commit 7f3048b:

⚠️ Validation status: warnings

File Status Preview URL Details
vcpkg/consume/third-party-authentication.md ⚠️Warning View Details
vcpkg/TOC.yml ✅Succeeded View
vcpkg/users/authentication.md ✅Succeeded View

vcpkg/consume/third-party-authentication.md

  • Line 42, Column 69: [Warning: bookmark-not-found - See documentation] Cannot find bookmark '#azurl' in 'users/assetcaching.md', did you mean '#x-azurl'?
  • Line 56, Column 1: [Warning: bookmark-not-found - See documentation] Cannot find bookmark '#AUTHORIZATION_TOKEN' in 'maintainers/functions/vcpkg_from_github.md'.
  • Line 58, Column 1: [Warning: bookmark-not-found - See documentation] Cannot find bookmark '#AUTHORIZATION_TOKEN' in 'maintainers/functions/vcpkg_from_gitlab.md'.
  • Line 66, Column 67: [Warning: bookmark-not-found - See documentation] Cannot find bookmark '#github-actions-cache' in 'reference/binarycaching.md'.
  • Line 73, Column 18: [Warning: bookmark-not-found - See documentation] Cannot find bookmark '#github-packages' in 'reference/binarycaching.md'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Contributor

@Thomas1664 Thomas1664 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not like the new article because it just acts like a „table of contents“. Users have to jump around in the documentation to find what they are looking for. Obviously, this assumes users know what they’re looking for. IMO rather than linking all over the place from this article, all the other articles should link to the new article which should provide the actual information.

Please also notice the warnings on wrong links.


To methods described below for [authenticating to Git repositories](#git) and
[NuGet feeds](#nuget) apply for repositories and artifact feeds hosted in Azure
DevOps. See the [tutorial for packaging an ADO
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should explain what ADO means.

---
# Authenticate to third-party services

vcpkg has features that leverage third-party services like Azure DevOps, Azure
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This article uses multiple ways to spell Azure Devops.

code repository, as a backend for binary caching, or running as part of an ADO
pipeline.

To methods described below for [authenticating to Git repositories](#git) and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To methods described below for [authenticating to Git repositories](#git) and
Two methods described below for [authenticating to Git repositories](#git) and

@vicroms vicroms marked this pull request as draft November 4, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants