Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document vcpkg_make_configure/install #388

Draft
wants to merge 34 commits into
base: main
Choose a base branch
from

Conversation

JavierMatosD
Copy link
Contributor

@JavierMatosD JavierMatosD commented Aug 19, 2024

Copy link

@JavierMatosD : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 7b6ee0d:

✅ Validation status: passed

File Status Preview URL Details
vcpkg/maintainers/functions/vcpkg_make_configure.md ✅Succeeded View
vcpkg/maintainers/functions/vcpkg_make_install.md ✅Succeeded View
vcpkg/TOC.yml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Yaml File(s) This PR includes changes to .yml file(s) owned by another author.
Commits Count This PR contains more than 15 commits.
File Change Percent This PR contains file(s) with more than 30% file change.

Copy link
Contributor

Learn Build status updates of commit 53261e7:

✅ Validation status: passed

File Status Preview URL Details
vcpkg/maintainers/functions/vcpkg_make_configure.md ✅Succeeded View
vcpkg/maintainers/functions/vcpkg_make_install.md ✅Succeeded View
vcpkg/TOC.yml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Yaml File(s) This PR includes changes to .yml file(s) owned by another author.
Commits Count This PR contains more than 15 commits.
File Change Percent This PR contains file(s) with more than 30% file change.

Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doc rocks, thank you!

vcpkg/maintainers/functions/vcpkg_make_configure.md Outdated Show resolved Hide resolved
Copy link
Contributor

Learn Build status updates of commit 4c37196:

✅ Validation status: passed

File Status Preview URL Details
vcpkg/maintainers/functions/vcpkg_make_configure.md ✅Succeeded View
vcpkg/maintainers/functions/vcpkg_make_install.md ✅Succeeded View
vcpkg/TOC.yml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Yaml File(s) This PR includes changes to .yml file(s) owned by another author.
Commits Count This PR contains more than 15 commits.
File Change Percent This PR contains file(s) with more than 30% file change.

Copy link
Contributor

Learn Build status updates of commit c52333c:

✅ Validation status: passed

File Status Preview URL Details
vcpkg/maintainers/functions/vcpkg_make_configure.md ✅Succeeded View
vcpkg/maintainers/functions/vcpkg_make_install.md ✅Succeeded View
vcpkg/TOC.yml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Yaml File(s) This PR includes changes to .yml file(s) owned by another author.
Commits Count This PR contains more than 15 commits.
File Change Percent This PR contains file(s) with more than 30% file change.

Copy link
Member

@vicroms vicroms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes. This looks pretty good already.

vcpkg/maintainers/functions/vcpkg_make_configure.md Outdated Show resolved Hide resolved
vcpkg/maintainers/functions/vcpkg_make_configure.md Outdated Show resolved Hide resolved
vcpkg/maintainers/functions/vcpkg_make_configure.md Outdated Show resolved Hide resolved
vcpkg/maintainers/functions/vcpkg_make_configure.md Outdated Show resolved Hide resolved
vcpkg/maintainers/functions/vcpkg_make_configure.md Outdated Show resolved Hide resolved
vcpkg/maintainers/functions/vcpkg_make_configure.md Outdated Show resolved Hide resolved
vcpkg/maintainers/functions/vcpkg_make_configure.md Outdated Show resolved Hide resolved
vcpkg/maintainers/functions/vcpkg_make_configure.md Outdated Show resolved Hide resolved
vcpkg/maintainers/functions/vcpkg_make_configure.md Outdated Show resolved Hide resolved
vcpkg/maintainers/functions/vcpkg_make_install.md Outdated Show resolved Hide resolved
Copy link
Contributor

Learn Build status updates of commit 496e186:

✅ Validation status: passed

File Status Preview URL Details
vcpkg/maintainers/functions/vcpkg_make_configure.md ✅Succeeded View
vcpkg/maintainers/functions/vcpkg_make_install.md ✅Succeeded View
vcpkg/TOC.yml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Yaml File(s) This PR includes changes to .yml file(s) owned by another author.
Commits Count This PR contains more than 15 commits.
File Change Percent This PR contains file(s) with more than 30% file change.

Copy link
Contributor

Learn Build status updates of commit 00bba6e:

✅ Validation status: passed

File Status Preview URL Details
vcpkg/maintainers/functions/vcpkg_make_configure.md ✅Succeeded View
vcpkg/maintainers/functions/vcpkg_make_install.md ✅Succeeded View
vcpkg/TOC.yml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Yaml File(s) This PR includes changes to .yml file(s) owned by another author.
Commits Count This PR contains more than 15 commits.
File Change Percent This PR contains file(s) with more than 30% file change.

@vicroms vicroms marked this pull request as draft November 15, 2024 09:21
@vicroms
Copy link
Member

vicroms commented Nov 15, 2024

Marked as draft until relevant feature is merged in the main repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants