Performance improvement for repository merge step

microsoft · Jul 12, 2019 · 634eecb · 634eecb
1 parent 8607334
commit 634eecb
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/library/Storage/UpdatesCache.cs b/src/library/Storage/UpdatesCache.cs
@@ -203,6 +203,7 @@ public void MergeQueryResult(QueryResult queryResult, CategoriesCache categories
             var parentRepositoryInternal = ParentRepository as IRepositoryInternal;
 
             List<Update> newBundlingUpdates = new List<Update>();
+            List<Update> addedUpdates = new List<Update>();
 
             foreach (var newUpdate in queryResult.Updates)
             {
@@ -212,6 +213,7 @@ public void MergeQueryResult(QueryResult queryResult, CategoriesCache categories
                     newUpdate.LastChanged = DateTime.Now;
 
                     Index.Add(newUpdate.Identity, newUpdate);
+                    addedUpdates.Add(newUpdate);
 
                     using (var newMetadataStream = File.OpenRead(queryResult.GetUpdateXmlPath(newUpdate)))
                     {
@@ -268,7 +270,8 @@ public void MergeQueryResult(QueryResult queryResult, CategoriesCache categories
                 var productsList = categories.Products.Values.ToList();
                 var classificationsList = categories.Classifications.Values.ToList();
 
-                foreach (var update in Index.Values)
+                // Fill in product and classification information.
+                foreach (var update in addedUpdates)
                 {
                     var updateWithProduct = update as IUpdateWithProductInternal;
                     if (updateWithProduct != null)