Fixed the bandorder of EuroSAT #2480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orial to align with [the issue raised in the EuroSAT git repository](phelber/EuroSAT#7)
github-actions
bot
added
documentation
|
@microsoft-github-policy-service agree |
adamjstewart
approved these changes
Dec 19, 2024
calebrob6
reviewed
Dec 19, 2024
| 'B10': 4.77584468, | ||
| 'B11': 1002.58768311, | ||
| 'B12': 761.30323499, | ||
| 'B8A': 1231.58581042, |
There was a problem hiding this comment.
These don't need to be moved around, this is a dictionary
There was a problem hiding this comment.
True, but it's better to keep them in the same order as everything else.
|
I don't think this is correct because we calculate the mean and stdev in whatever order the channels are seen in the files |
Correct, and since we're changing the order of the band names in the files, we also need to change the order of the mean/std dev we apply. |
adamjstewart
pushed a commit
that referenced
this pull request
Dec 19, 2024
…orial to align with [the issue raised in the EuroSAT git repository](phelber/EuroSAT#7) (#2480)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes applied to dataset, datamodule and within the tutorial to align with the issue raised in the EuroSAT git repository.
Fixes #2458
I did not check other Sentinel-2 datasets.