Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update with plot class for eddmaps,gbif,mm_earth,inaturalist,western_usa_live_fuel_mositure #2475

Closed

Conversation

preethatr07
Copy link

No description provided.

@github-actions github-actions bot added the datasets Geospatial or benchmark datasets label Dec 17, 2024
@preethatr07 preethatr07 changed the title Update with plot class for eddmaps.py Update with plot class for eddmaps,gbif,mm_earth,inaturalist,western_usa_live_fuel_mositure Dec 17, 2024
@adamjstewart
Copy link
Collaborator

Can you open a separate PR for each dataset? Also, the plot function signature should match all of our other datasets:

    def plot(
        self,
        sample: dict[str, Any],
        show_titles: bool = True,
        suptitle: str | None = None,
    ) -> Figure:
        """Plot a sample from the dataset.

        Args:
            sample: a sample returned by :meth:`__getitem__`
            show_titles: flag indicating whether to show titles above each panel
            suptitle: optional string to use as a suptitle

        Returns:
            a matplotlib Figure with the rendered sample

        .. versionadded:: 0.7
        """

So we are plotting a single sample returned by __getitem__, we aren't plotting the entire dataset or creating a new sample in the plot function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasets Geospatial or benchmark datasets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants