Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade nx to 12.10.1 #2561

Merged
merged 1 commit into from
May 1, 2024
Merged

upgrade nx to 12.10.1 #2561

merged 1 commit into from
May 1, 2024

Conversation

imatiach-msft
Copy link
Contributor

@imatiach-msft imatiach-msft commented Apr 26, 2024 •
edited
Loading

Description

Recently node-gyp errors started appearing on macos builds:

  File "/Users/runner/work/responsible-ai-toolbox/responsible-ai-toolbox/node_modules/node-gyp/gyp/pylib/gyp/input.py", line 234, in LoadOneBuildFile
    build_file_contents = open(build_file_path, 'rU').read()
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: invalid mode: 'rU' while trying to load binding.gyp

Based on stackoverflow issue here:

https://stackoverflow.com/questions/74715990/node-gyp-err-invalid-mode-ru-while-trying-to-load-binding-gyp

It seems the recommendation is to upgrade node-gyp to version 8 or above. However, we have a very old version of nx which depends on this old version of node-gyp. Hence, sending this PR to upgrade nx to 12.x latest version, although even this major version is very old - it is recommended to upgrade nx in stages:

https://nx.dev/recipes/tips-n-tricks/advanced-update#one-major-version-at-a-time-small-steps

This means there may be a series of PRs sent out to upgrade nx for each major version. Attempting to upgrade to the very latest is currently throwing many errors.

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@imatiach-msft imatiach-msft force-pushed the ilmat/upgrade-nx-12.10.1 branch 2 times, most recently from dd17b43 to c237fe2 Compare April 29, 2024 14:58
@github-actions GitHub Actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/ilmat/upgrade-nx-12.10.1/dashboard/index.html

@imatiach-msft imatiach-msft force-pushed the ilmat/upgrade-nx-12.10.1 branch 5 times, most recently from aa86d03 to c0919ea Compare April 29, 2024 17:27
@github-actions GitHub Actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/ilmat/upgrade-nx-12.10.1/dashboard/index.html

1 similar comment
@github-actions GitHub Actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/ilmat/upgrade-nx-12.10.1/dashboard/index.html

@imatiach-msft imatiach-msft force-pushed the ilmat/upgrade-nx-12.10.1 branch 4 times, most recently from cdfe9c5 to bb80446 Compare April 29, 2024 19:46
@github-actions GitHub Actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/ilmat/upgrade-nx-12.10.1/dashboard/index.html

2 similar comments
@github-actions GitHub Actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/ilmat/upgrade-nx-12.10.1/dashboard/index.html

@github-actions GitHub Actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/ilmat/upgrade-nx-12.10.1/dashboard/index.html

@github-actions GitHub Actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/ilmat/upgrade-nx-12.10.1/dashboard/index.html

@github-actions GitHub Actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/ilmat/upgrade-nx-12.10.1/dashboard/index.html

@github-actions GitHub Actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/ilmat/upgrade-nx-12.10.1/dashboard/index.html

@github-actions GitHub Actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/ilmat/upgrade-nx-12.10.1/dashboard/index.html

@github-actions GitHub Actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/ilmat/upgrade-nx-12.10.1/dashboard/index.html

@github-actions GitHub Actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/ilmat/upgrade-nx-12.10.1/dashboard/index.html

@github-actions GitHub Actions
Copy link

https://responsibleai.blob.core.windows.net/pullrequest/microsoft/responsible-ai-toolbox/ilmat/upgrade-nx-12.10.1/dashboard/index.html

@imatiach-msft imatiach-msft merged commit 6026326 into main May 1, 2024
80 checks passed
@imatiach-msft imatiach-msft deleted the ilmat/upgrade-nx-12.10.1 branch May 1, 2024 17:09
@imatiach-msft imatiach-msft mentioned this pull request May 1, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RubyZ10 RubyZ10 RubyZ10 approved these changes

@vinuthakaranth vinuthakaranth Awaiting requested review from vinuthakaranth vinuthakaranth is a code owner

@tongyu-microsoft tongyu-microsoft Awaiting requested review from tongyu-microsoft tongyu-microsoft is a code owner

@xuke444 xuke444 Awaiting requested review from xuke444 xuke444 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imatiach-msft @RubyZ10